refactor: rm send_message from MlsTransport#1986
Merged
coriolinus merged 9 commits intomainfrom Mar 27, 2026
Merged
Conversation
We never actually use this method and didn't document what clients were actually supposed to do to implement it, so it's not like it's doing anyone any good. Simpler interfaces are better. No dead code is better than some dead code.
SimonThormeyer
approved these changes
Mar 27, 2026
Member
SimonThormeyer
left a comment
SimonThormeyer
left a comment
There was a problem hiding this comment.
Looks good, assuming green CI.
coriolinus
force-pushed
the
prgn/refactor/rm-send-message
branch
from
f3bf334 to
1a69fc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
It was poorly documented, and we never called it.
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.